Ensure to call jl_islayout_inline() even in the case @assert is deactivated

[petershintech]

No description provided.

[yuyichao]

Why?

Edit: Nvm, I missed the argument..

[ararslan]

Thanks for the contribution @petershintech! It would be good to know what the justification for the change is. Could you provide some more information?

[jlapeyre]

See this thread: https://discourse.julialang.org/t/no-problem-with-more-than-500-assert-statements-in-v1-0-3/19255

I don't think this PR offers an advantage at the moment. But, if there is a mechanism to turn off assertions in the future, then the code will fail without this PR.

[KristofferC]

This is the docs for @assert:

│ Warning
│
│ An assert might be disabled at various optimization levels. Assert should therefore only be used as a
│ debugging tool and not used for authentication verification (e.g., verifying passwords), nor should
│ side effects needed for the function to work correctly be used inside of asserts.

So this LGTM.

[petershintech]

Yes. The problem is, this code depends on the side effect of the @Assert statement to return a correct result.