Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #30792, static param constraints between positional and kw args #30798

Merged
merged 1 commit into from
Jan 23, 2019
Merged

fix #30792, static param constraints between positional and kw args #30798

merged 1 commit into from
Jan 23, 2019

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added compiler:lowering Syntax lowering (compiler front end, 2nd stage) bugfix This change fixes an existing bug keyword arguments f(x; keyword=arguments) labels Jan 22, 2019
ararslan
ararslan reviewed Jan 22, 2019
View reviewed changes
src/julia-syntax.scm Outdated Show resolved Hide resolved
@StefanKarpinski
Copy link
Member

Any backports appropriate or is this too obscure?

@lostella
Copy link
Contributor

I'll be using this if backported to 1.0 and 1.1 :-)

@JeffBezanson
Copy link
Member Author

Should be safe to backport. I guess we might as well since there is a request for it.

@JeffBezanson JeffBezanson merged commit 4b74158 into master Jan 23, 2019
@JeffBezanson JeffBezanson deleted the jb/fix30792 branch January 23, 2019 21:38
@StefanKarpinski StefanKarpinski added triage This should be discussed on a triage call backport 1.1 and removed backport 1.0 triage This should be discussed on a triage call labels Jan 31, 2019
@JeffBezanson JeffBezanson removed triage This should be discussed on a triage call triage backport pending 1.0 labels Jan 31, 2019
@StefanKarpinski StefanKarpinski removed the triage This should be discussed on a triage call label Jan 31, 2019
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@JeffBezanson @KristofferC
fix #30792, static param constraints between positional and kw args (#…
d93ef2c 
…30798)

(cherry picked from commit 4b74158)
@KristofferC KristofferC mentioned this pull request Feb 4, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@JeffBezanson @KristofferC
fix #30792, static param constraints between positional and kw args (#…
268257d 
…30798)

(cherry picked from commit 4b74158)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@JeffBezanson @KristofferC
fix #30792, static param constraints between positional and kw args (#…
8d8b0f2 
…30798)

(cherry picked from commit 4b74158)
@KristofferC KristofferC mentioned this pull request Feb 11, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@JeffBezanson @KristofferC
fix #30792, static param constraints between positional and kw args (#…
f9dddf8 
…30798)

(cherry picked from commit 4b74158)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@JeffBezanson @KristofferC
fix #30792, static param constraints between positional and kw args (#…
0791c50 
…30798)

(cherry picked from commit 4b74158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan left review comments

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage) keyword arguments f(x; keyword=arguments)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeffBezanson @StefanKarpinski @lostella @ararslan