[wip] support using tasks on threads (2/3) #30838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha, it's good ol' You're trying to support old-style threaded loops with these multiple |
|
The old Workqueue (extended here to threads) should be the same as the partr sticky queue, I'm just keeping more of the implementation in Julia here. |
JeffBezanson
reviewed
Mar 6, 2019
base/boot.jl
Outdated
| @@ -380,8 +380,8 @@ eval(Core, :(LineInfoNode(mod::Module, method::Symbol, file::Symbol, line::Int, | |||
|
|
|||
| Module(name::Symbol=:anonymous, std_imports::Bool=true) = ccall(:jl_f_new_module, Ref{Module}, (Any, Bool), name, std_imports) | |||
|
|
|||
| function Task(@nospecialize(f), reserved_stack::Int=0) | |||
| return ccall(:jl_new_task, Ref{Task}, (Any, Int), f, reserved_stack) | |||
| function Task(@nospecialize(f), reserved_stack::Int, completion_future) | |||
There was a problem hiding this comment.
We probably don't want to expose this argument --- should either rename this method or assign the field in the other Task constructor.
JeffBezanson
force-pushed
the
jn/task-thread
branch
from
197922a
to
e11ace9
Compare
JeffBezanson
pushed a commit
that referenced
this pull request
Mar 19, 2019
raphbacher
pushed a commit
to raphbacher/julia
that referenced
this pull request
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread-safety for Workqueue, permit interacting with Tasks from threads
TODO: