Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JULIA_DEPOT_PATH: expand empty path to default #31009

Merged
merged 4 commits into from
Feb 15, 2019
Merged

JULIA_DEPOT_PATH: expand empty path to default #31009

merged 4 commits into from
Feb 15, 2019
+128 −31

Conversation

StefanKarpinski
Copy link
Member

This makes the behavior for JULIA_DEPOT_PATH expansion match that of
JULIA_LOAD_PATH expansion and allows one to manipulate the path
uncondionally with shell expressions like this:

export JULIA_DEPOT_PATH="$JULIA_DEPOT_PATH:/system/depot"

It also changes JULIA_LOAD_PATH expansion to do user name expansion just
like JULIA_DEPOT_PATH does, bringing the two variables into closer
behavioral agreement.

@StefanKarpinski
Copy link
Member Author

StefanKarpinski commented Feb 8, 2019 •
edited
Loading

Implements #31002 on top of #31010.

@StefanKarpinski StefanKarpinski added speculative Whether the change will be implemented is speculative minor change Marginal behavior change acceptable for a minor release labels Feb 8, 2019
@StefanKarpinski StefanKarpinski added this to the 1.2 milestone Feb 8, 2019
@StefanKarpinski StefanKarpinski added the needs news A NEWS entry is required for this change label Feb 8, 2019
@StefanKarpinski StefanKarpinski added the triage This should be discussed on a triage call label Feb 8, 2019
fredrikekre
fredrikekre approved these changes Feb 12, 2019
View reviewed changes
base/initdefs.jl Outdated Show resolved Hide resolved
@StefanKarpinski StefanKarpinski removed the speculative Whether the change will be implemented is speculative label Feb 13, 2019
@JeffBezanson
Copy link
Member

Triage approves.

@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Feb 14, 2019
StefanKarpinski and others added 3 commits February 15, 2019 00:11
@StefanKarpinski @fredrikekre
JULIA_DEPOT_PATH: expand empty path to default
59ddc77 
This makes the behavior for JULIA_DEPOT_PATH expansion match that
of JULIA_LOAD_PATH expansion and allows one to manipulate the path
uncondionally with shell expressions like this:

    export JULIA_DEPOT_PATH="$JULIA_DEPOT_PATH:/system/depot"

It also changes JULIA_LOAD_PATH expansion to do user name expansion
just like JULIA_DEPOT_PATH does, bringing the two variables into
closer behavioral agreement.
@StefanKarpinski @fredrikekre
update DEPOT_PATH and JULIA_DEPOT_PATH docs
cf2f6f2
@fredrikekre
Tests for JULIA_LOAD_PATH and JULIA_DEPOT_PATH expansions.
0a9faeb
@fredrikekre
Copy link
Member

fredrikekre commented Feb 14, 2019 •
edited
Loading

Pushed some test cases and news.

@fredrikekre fredrikekre removed the needs news A NEWS entry is required for this change label Feb 14, 2019
@StefanKarpinski
Copy link
Member Author

Thank you, @fredrikekre! You are the best.

@fredrikekre fredrikekre merged commit 8b5ab23 into master Feb 15, 2019
@fredrikekre fredrikekre deleted the sk/depot-path branch February 15, 2019 10:37
@mortenpi mortenpi mentioned this pull request Mar 5, 2019
Closed
@StefanKarpinski StefanKarpinski mentioned this pull request Apr 30, 2020
Closed
@laborg laborg mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

@mortenpi mortenpi mortenpi left review comments

Assignees
No one assigned
Labels
minor change Marginal behavior change acceptable for a minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StefanKarpinski @JeffBezanson @fredrikekre @mortenpi