Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import partr code, allow using it in threaded loops #31398

Merged
merged 2 commits into from
Mar 22, 2019
Merged

import partr code, allow using it in threaded loops #31398

merged 2 commits into from
Mar 22, 2019

Conversation

JeffBezanson
Copy link
Member

Rebased version of #30731.

@JeffBezanson JeffBezanson added the multithreading Base.Threads and related functionality label Mar 19, 2019
@vchuravy
Copy link
Member

So if I read this right tasks are only processed on the workers if we are in a threaded loop, but only the ones that are started by @threads and not the ones that are queued up outside?

@StefanKarpinski StefanKarpinski mentioned this pull request Mar 19, 2019
Closed
@vtjnash
Copy link
Member

vtjnash commented Mar 19, 2019

It'll make progress on all tasks while inside an @threads block. Outside that block, the logic to automatically (dis)engage the @threads logic is currently not implemented.

vtjnash
vtjnash reviewed Mar 21, 2019
View reviewed changes
base/task.jl Outdated Show resolved Hide resolved
src/task.c Show resolved Hide resolved
@vtjnash @JeffBezanson
enable partr backend
d9d8d4c 
drop/fix more broken code
drop jl_thread_sleep_threshold deadcode
improve jl_wakeup_thread
@JeffBezanson JeffBezanson mentioned this pull request Mar 21, 2019
Merged
@JeffBezanson JeffBezanson merged commit 6a28aa9 into master Mar 22, 2019
@martinholters martinholters deleted the jn/kp/partr2 branch March 22, 2019 18:34
@kpamnany kpamnany mentioned this pull request Mar 26, 2019
Closed
@AzamatB
Copy link
Contributor

AzamatB commented Mar 27, 2019

Does this mean that the functionality of #22631 is now added to the Julia?

@chriscoey chriscoey mentioned this pull request Apr 15, 2019
Closed
@stevengj stevengj mentioned this pull request Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeffBezanson @vchuravy @vtjnash @AzamatB