add locks for libuv #31437
Merged
add locks for libuv #31437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
io
This was referenced Mar 21, 2019
yuyichao
reviewed
Mar 22, 2019
| if ((err = uv_pipe_init(jl_io_loop, (uv_pipe_t*)handle, 0))) { | ||
| // JL_UV_UNLOCK() equivalent is done during unwinding |
There was a problem hiding this comment.
Errr, no. This is not the case for the NOGC version of the lock.
There was a problem hiding this comment.
I think the locks here can just be removed; threads haven't been started yet at this point.
| static uv_loop_t *const unused_uv_loop_arg = (uv_loop_t *)0xBAD10; | ||
|
|
||
| extern jl_mutex_t jl_uv_mutex; | ||
| #define JL_UV_LOCK() JL_LOCK_NOGC(&jl_uv_mutex) |
There was a problem hiding this comment.
Has this been tested under heavy GC to make sure that none of the locked code ever touches the GC (or better, by adding an assertion on GC entry that this lock is not held)?
There was a problem hiding this comment.
No, we know for a fact that we hold this lock while doing arbitrary user computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and squashed version of #29706.