Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes to libuv locks #31454

Merged
merged 1 commit into from
Mar 26, 2019
Merged

small fixes to libuv locks #31454

merged 1 commit into from
Mar 26, 2019

Conversation

JeffBezanson
Copy link
Sponsor Member

  • use normal locking instead of nogc
  • remove locks before threads have started
  • add a trylock function (previously we only had trylock_nogc)

@JeffBezanson JeffBezanson added io Involving the I/O subsystem: libuv, read, write, etc. multithreading Base.Threads and related functionality labels Mar 22, 2019
@vtjnash
Copy link
Sponsor Member

vtjnash commented Mar 23, 2019

  Error while loading expression starting at /tmp/julia/share/julia/test/cmdlineargs.jl:87
  caused by [exception 1]
  failed process: Process(`/tmp/julia/bin/julia -Cnative -J/tmp/julia/lib/julia/sys.so --depwarn=error --check-bounds=yes -g1 --startup-file=no -v`, ProcessSignaled(11)) [0]

@JeffBezanson
Copy link
Sponsor Member Author

Looks to me like jl_parse_opts should not call jl_exit, since julia_init has not been called yet.

- use normal locking instead of nogc
- remove locks before threads have started
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io Involving the I/O subsystem: libuv, read, write, etc. multithreading Base.Threads and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants