Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused check_new_version code #31800

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Remove unused check_new_version code #31800

merged 1 commit into from
Apr 23, 2019

Conversation

fredrikekre
Copy link
Member

No description provided.

@StefanKarpinski
Copy link
Member

I definitely agree with deleting check_new_version but the other utility functions are pretty useful.

@fredrikekre fredrikekre changed the title Remove some unused VersionNumber code Remove unused check_new_version code Apr 23, 2019
@fredrikekre
Copy link
Member Author

Okay, dropped those commits.

@fredrikekre fredrikekre merged commit 5741c7f into master Apr 23, 2019
@fredrikekre fredrikekre deleted the fe/version branch April 23, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @StefanKarpinski