Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL docs for __init__ #31930

Merged
merged 4 commits into from
May 14, 2019
Merged

REPL docs for __init__ #31930

merged 4 commits into from
May 14, 2019

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented May 5, 2019

Address #28730

giordano
giordano reviewed May 6, 2019
View reviewed changes
base/docs/basedocs.jl Outdated Show resolved Hide resolved
@Moelf
Copy link
Contributor Author

Moelf commented May 10, 2019

not sure why the build test failed.

@StefanKarpinski StefanKarpinski requested a review from vtjnash May 14, 2019 13:07
@StefanKarpinski
Copy link
Member

@vtjnash, would you mind reviewing the text of this doc string and approving if it looks factually accurate?

@vtjnash vtjnash merged commit 0523d1d into JuliaLang:master May 14, 2019
@fredrikekre fredrikekre mentioned this pull request May 14, 2019
Closed
@Moelf Moelf deleted the __init__doc branch May 15, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Moelf @StefanKarpinski @vtjnash @giordano