Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with external LLVM #31957

Merged
merged 1 commit into from
May 14, 2019
Merged

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented May 7, 2019

These patches probably should not be included if we're building with an external (likely modified LLVM).

@vtjnash
Copy link
Sponsor Member

vtjnash commented May 7, 2019

You might still want this patch, though? Granted, I usually just turn them into a commit (or touch the .patch-applied file) so that I can work around them.

@vtjnash vtjnash requested a review from vchuravy May 7, 2019 18:46
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did say folks who compile from svn life their life dangerously enough to also take the risk of loading multiple version of LLVM and having them clash

@JeffBezanson
Copy link
Sponsor Member

Should we merge this? It makes sense to me. If you're using svn you can apply patches manually as needed.

@vchuravy vchuravy merged commit 236df47 into JuliaLang:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants