treat Pair as broadcast scalar #32209
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
added
broadcast
|
Yeah, this is probably the way to go here. It's unlikely that it's useful to broadcast the same function over both sides of the pair. It is definitely breaking, though. |
|
CI failures are unrelated #32186. |
|
Comment from triage (Jeff): it's probably not great that pairs are even iterable and we probably only allow it for destructuring. Triage is in favor of changing this. |
|
Rebased to fix NEWS conflict. Should be good to merge. |
|
I'm going to go ahead and merge shortly since triage was in favor and no one has objected to this; it seems to have fallen under the radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on discourse, it seems much more useful to treat
Pairas a scalar for broadcast. (There are other iterable objects, e.g.String, that are also broadcast scalars.)The example on the mailing list was
replace.(["string1", "string2", ...], pat=>rep), and one can come up with many others. Conversely, I find it hard to imagine any case where iterating over the pair would be useful in a broadcast context, especially since the output is an array rather than anotherPair:Hence I'm marking this as a "minor change" — technically breaking, but unlikely to affect real code.