Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few methods to manual & fix doctests #32417

Merged
merged 8 commits into from
Jun 27, 2019

Conversation

mortenpi
Copy link
Contributor

@mortenpi mortenpi commented Jun 26, 2019

Primarily this is fixing outdated doctests that are not being currently tested because the associated docstrings are not included in the manual. But I also discovered an unused broken function (Distributed.head_and_tail) and a few methods that were not included in the man pages, but probably should.

The commit messages have more details.

It does touch quite a few different parts of the code, so I can also separate this into different PRs if that would help the review.

These were revealed by #32376.

@mortenpi mortenpi mentioned this pull request Jun 26, 2019
3 tasks
@mortenpi
Copy link
Contributor Author

mortenpi commented Jun 26, 2019

Scratch that -- Distributed.head_and_tail is not unused. It's used in the very next function.. not sure how I missed that. But the last return does look broken and should cause the doctest to fail.

Edit: removed the Distributed.head_and_tail fix in favor of #32431

mortenpi added 8 commits June 27, 2019 10:28
This is not, strictly speaking, well defined. There is no official rule
as to which docstring should get executed first.

This will not be supported in a future version of Documenter.
Also fix the doctest in the docstring. The simpler println variant seems
to be more reliable when printing from a another task (with at-show, the
"Hello" string did not actually get printed).
The function is not exported.  Note that it does not currently get
doctested, but will be tested in a future Documenter version.
This is not currently included in the manual and therefore not
doctested, but will be in the future.
Not currently doctested since it is not included in the manual, but will
be in the future.
Also fix a doctest in one of the docstrings.
And fix the doctests in the docstrings.
Fix doctests in the docstrings of LinearAlgebra.isbanded, 
LinearAlgebra.promote_leaf_eltypes and SparseArrays.dropstored!. All the 
functions are unexported and not included in the manual.

They are currently not being doctested, but will be with a future 
version of Documenter.
@fredrikekre fredrikekre merged commit 042504d into JuliaLang:master Jun 27, 2019
@fredrikekre fredrikekre added the docs This change adds or pertains to documentation label Jun 27, 2019
@mortenpi mortenpi deleted the mp/doctestfix branch June 27, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants