deprecate unused and not-recommended Threads.Mutex
#32875
Merged
+13
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this could be breaking. Perhaps deprecate instead of hard removal? |
|
The Threads module is marked as experimental. That said, I'd guess that some trivial uses might be covered by a |
|
We could deprecate the binding to |
JeffBezanson
force-pushed
the
jb/rmMutex
branch
from
b3d5086 to
b7e94ba
Compare
mbauman
changed the title
Threads.MutexThreads.Mutex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of lock is not really compatible with our threading model. The only reason to use it would be for a lock held for a long period of time, but in that case the lock should be task-blocking (
ReentrantLock) instead of thread-blocking, so other tasks can run.Closes #32874
Closes #32873