use precompile generation for Distributed instead of hardcoded list #33077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
parallelism
|
With this we could probably delete the precompile.jl file for |
KristofferC
force-pushed
the
kc/distributed
branch
from
a232c07 to
94f1aa6
Compare
KristofferC
force-pushed
the
kc/distributed
branch
from
94f1aa6 to
b2f99ac
Compare
|
Removed the Sockets precompile file as well. I looked at the generated precompile statements and there was a bunch of Socket stuff in there. |
|
Good to go? |
|
It's surprising how much time this adds to the build. After: Not a huge problem maybe, but it did kind of surprise me. |
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally, we just delete the
precompilefile in Distributed and do no precompilation for it.Fixes #31938