Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate include(::String) for nicer stacktraces #33087

Merged
merged 3 commits into from
Aug 28, 2019

Conversation

antoine-levitt
Copy link
Contributor

@antoine-levitt antoine-levitt commented Aug 27, 2019

See #33065 (comment)

Before:

ERROR: LoadError: UndefVarError: STOP not defined
Stacktrace:
 [1] top-level scope at /home/antoine/scratch.jl:1
 [2] include at ./boot.jl:328 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1105
 [4] include(::Module, ::String) at ./Base.jl:31
 [5] include(::String) at ./client.jl:432
 [6] top-level scope at REPL[2]:1
in expression starting at /home/antoine/scratch.jl:1

After:

julia> include("scratch.jl")
ERROR: LoadError: UndefVarError: STOP not defined
Stacktrace:
 [1] top-level scope at /home/antoine/scratch.jl:1
 [2] include(::String) at /home/antoine/julia-fork/base/client.jl:443
 [3] top-level scope at REPL[4]:1
in expression starting at /home/antoine/scratch.jl:1

@KristofferC
Copy link
Sponsor Member

Unfortunate to have to duplicate code but this code rarely change and it has an impactful change to the stacktrace printing so +1 from me.

@JeffBezanson JeffBezanson merged commit 9a8b2fd into JuliaLang:master Aug 28, 2019
vtjnash added a commit that referenced this pull request Sep 13, 2019
Using the ability to delete functions, we can make this code a bit nicer and simpler.
(similar to #33087)
vtjnash added a commit that referenced this pull request Sep 13, 2019
Using the ability to delete functions, we can make this code a bit nicer and simpler.
(similar to #33087)
vtjnash added a commit that referenced this pull request Sep 13, 2019
Using the ability to delete functions, we can make this code a bit nicer and simpler.
(similar to #33087)
vtjnash added a commit that referenced this pull request Sep 17, 2019
Using the ability to delete functions, we can make this code a bit nicer and simpler.
(similar to #33087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants