Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tempname: add parent and cleanup arguments #33090

Merged
merged 3 commits into from
Aug 28, 2019
Merged

tempname: add parent and cleanup arguments #33090

merged 3 commits into from
Aug 28, 2019

Conversation

StefanKarpinski
Copy link
Member

@StefanKarpinski StefanKarpinski commented Aug 27, 2019 •
edited
Loading

I think that adding parent and cleanup to tempname to match all the other temp file functions only makes sense. Whether the default for cleanup should be true or false is more debatable. I think it should be true to match all the other temp path functions.

@StefanKarpinski StefanKarpinski mentioned this pull request Aug 27, 2019
Closed
@StefanKarpinski StefanKarpinski added needs compat annotation Add !!! compat "Julia x.y" to the docstring needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels Aug 27, 2019
oxinabox
oxinabox reviewed Aug 27, 2019
View reviewed changes
base/file.jl Outdated Show resolved Hide resolved
oxinabox
oxinabox reviewed Aug 27, 2019
View reviewed changes
base/file.jl Show resolved Hide resolved
@StefanKarpinski StefanKarpinski removed the needs compat annotation Add !!! compat "Julia x.y" to the docstring label Aug 27, 2019
@StefanKarpinski StefanKarpinski force-pushed the sk/tempname branch 4 times, most recently from ff2fdb5 to 8b89b58 Compare August 27, 2019 20:17
oxinabox
oxinabox reviewed Aug 27, 2019
View reviewed changes
base/file.jl Outdated Show resolved Hide resolved
test/file.jl Outdated Show resolved Hide resolved
@StefanKarpinski StefanKarpinski merged commit 0e00974 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the sk/tempname branch August 28, 2019 13:39
@vtjnash vtjnash removed needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels Aug 29, 2019
@vtjnash vtjnash mentioned this pull request Sep 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanKarpinski @oxinabox @vtjnash