-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GMP and MPFR builds to use better compiler flags #33096
Conversation
Note, should revert #32102 on backport branch when backporting this. |
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Looks like the error on mac is real:
|
So my investigation of this so far points to this being due to compiling with
Whereas the new one (built with
I do not yet grok the import of having that extra undefined symbol, but I can only guess that it's due to some internal compiler difference. |
347b8cc
to
c2d1372
Compare
I believe, in my furious binary building for Gtk, I may have nudged around compiler options to the point that we no longer get double symbols. I've rebased this, let's see if it is indeed the case. |
Just for good measure: @nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Nice! |
BigFloat speedups across the board! |
(cherry picked from commit b685cf6)
This incorporates GMP and MPFR, built using the new BB, that should have better performance attributes (GCC no longer defaulting to ancient processor variants), getting us back our bigfloat performance.
Closes #31759
Eligible for backporting wherever we think it might be helpful (1.3 for sure, 1.2 possibly?)
On my linux64 machine, comparing three builds of julia:
julia-release-1.2
: builds GMP/MPFR from-source to dodge this issuejulia-master
: triggers the slowdown./julia
: contains this fix