Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have threading functions (lock, unlock, ...) throw Error for old Base.Condition #33162

Merged
merged 3 commits into from
Sep 12, 2019

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Sep 4, 2019

Address the issue referenced in #30061 (comment):

The old-style Base.Condition is NOT thread-safe and does not support the threading API. This PR tries to help the user notice when they should be using Threads.Condition by throwing an error to fail early.

If there are other functions we should add error-throwing overloads for, please let me know.

@JeffBezanson JeffBezanson added the multithreading Base.Threads and related functionality label Sep 4, 2019
base/condition.jl Outdated Show resolved Hide resolved
@JeffBezanson JeffBezanson merged commit 668341e into JuliaLang:master Sep 12, 2019
@NHDaly NHDaly deleted the old-Condition-error-lock branch September 13, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multithreading Base.Threads and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants