Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast AbstractRNG like a scalar #33213

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Broadcast AbstractRNG like a scalar #33213

merged 3 commits into from
Sep 23, 2019

Conversation

nickrobinson251
Copy link
Contributor

@nickrobinson251 nickrobinson251 commented Sep 10, 2019 •
edited
Loading

  • closes AbstractRNG should be a broadcast scalar #31071
  • i think this is in-keeping with the de-facto heuristic on how things broadcast, which i think of as "something that's obviously not a collection broadcasts like a scalar, as long as there's a reasonable use-case for that behaviour"
  • ideally we'd test this on a new/test-only AbstractRNG, but i wasn't sure exactly what would need to be implemented and if it'd be worth it... so this is just tested on the two subtypes definited in the module :)

@nickrobinson251 nickrobinson251 force-pushed the npr/broadcast-rng-as-scalar branch from 7f9501c to efd8a0f Compare September 10, 2019 19:28
oxinabox
oxinabox reviewed Sep 16, 2019
View reviewed changes
NEWS.md Show resolved Hide resolved
stevengj
stevengj requested changes Sep 17, 2019
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@nickrobinson251 nickrobinson251 force-pushed the npr/broadcast-rng-as-scalar branch from b63df1f to efd8a0f Compare September 17, 2019 15:37
@mbauman mbauman added broadcast Applying a function over a collection randomness Random number generation and the Random stdlib labels Sep 23, 2019
@mbauman mbauman merged commit 187ee96 into JuliaLang:master Sep 23, 2019
@oxinabox oxinabox mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

@oxinabox oxinabox oxinabox left review comments

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
broadcast Applying a function over a collection randomness Random number generation and the Random stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AbstractRNG should be a broadcast scalar
5 participants
@nickrobinson251 @stevengj @oxinabox @fredrikekre @mbauman