add a subtyping fast path for tuple of Unions <: Vararg #33353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
performance
|
Test? |
JeffBezanson
force-pushed
the
jb/fix33337_2
branch
from
3c2a6bd to
9dd7b5b
Compare
Keno
approved these changes
Sep 21, 2019
18 tasks
vtjnash
reviewed
Sep 23, 2019
| @@ -1049,6 +1049,10 @@ static int subtype_tuple_tail(struct subtype_tuple_env *env, int8_t R, jl_stenv_ | |||
| yi = jl_tparam0(jl_unwrap_unionall(env->vty)); | |||
| if (!env->vvx && yi == (jl_value_t*)jl_any_type) | |||
| goto done; // if y ends in `Vararg{Any}` skip checking everything | |||
| // var T in Vararg{T} is diagonal; an abstract type can't be a subtype of it, | |||
| // so avoid exponential blowup when xi is a Union. | |||
| if (jl_is_typevar(yi) && jl_is_uniontype(xi) && !jl_has_free_typevars(xi)) | |||
There was a problem hiding this comment.
There’s also a concrete_min (which does this for obvious-subtype). But we discovered this was false, I thought, because T wasn’t know to be diagonal
There was a problem hiding this comment.
Hmm, ok, I can patch that up.
JeffBezanson
added a commit
that referenced
this pull request
Oct 1, 2019
JeffBezanson
added a commit
that referenced
this pull request
Oct 2, 2019
KristofferC
pushed a commit
that referenced
this pull request
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33337
Replacement for #33345 that improves subtyping instead of reverting.