Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document internal Ryu functions, remove duplicate functionality. #33406

Merged
merged 2 commits into from
Sep 29, 2019
Merged

Document internal Ryu functions, remove duplicate functionality. #33406

merged 2 commits into from
Sep 29, 2019

Conversation

simonbyrne
Copy link
Contributor

Also moved some functions from Math to Base.

@simonbyrne simonbyrne requested a review from quinnj September 27, 2019 21:35
@simonbyrne
Document internal Ryu functions, remove duplicate functionality.
893b32b 
Also moved some functions from Math to Base.
@simonbyrne simonbyrne added docs This change adds or pertains to documentation maths Mathematical functions labels Sep 27, 2019
quinnj
quinnj approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; great cleanups.

@simonbyrne simonbyrne merged commit d036575 into master Sep 29, 2019
@simonbyrne simonbyrne deleted the sb/ryu-doc branch September 29, 2019 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation maths Mathematical functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonbyrne @Keno @quinnj