faster replace on Dict and Set #33739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
collections
|
Bump. Who might be good to review this? |
|
Bump |
rfourquet
force-pushed
the
rf/replace-Dict
branch
from
a9801af to
aba0519
Compare
|
I just reviewed in detail, LGTM ;-) |
vtjnash
approved these changes
Oct 4, 2020
Just make sure CI pass first :P |
rfourquet
force-pushed
the
rf/replace-Dict
branch
from
aba0519 to
1384703
Compare
Oh right! since this PR, I fixed a bug 6 months ago (#35450) with new tests which fail here, because of a missing |
rfourquet
force-pushed
the
rf/replace-Dict
branch
from
1384703 to
8dd7920
Compare
|
There is one unrelated test failure with Dowloads (https://build.julialang.org/#/builders/33/builds/4397/steps/5/logs/stdio) : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes
replaceandreplace!functions onDict(andSet) based on the internals. The most spectacular improvements is when dict elements are replaced with another element with the same key: then the old value can be overwritten directly, and the time taken byreplacebasically doesn't depend anymore on the number of replaced elements, just the length of the dict.The following table shows examples of speed-up for different proportions of replaced elements:
When the keys change, the speedup seems to be generally between 30 and 40%. Not as nice, but still a modest improvement.