remove special cases for Main in system image saving
#34828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/savemain
branch
from
df12262
to
c110d74
Compare
|
Ha, this also found a bug in |
`usings` and all bindings will now be preserved make Core a top-level module (its parent is itself) instead of setting its parent to Main.
JeffBezanson
force-pushed
the
jb/savemain
branch
from
c110d74
to
9399a78
Compare
vtjnash
reviewed
Feb 24, 2020
Co-Authored-By: Jameson Nash <vtjnash@gmail.com>
Closed
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
`usings` and all bindings will now be preserved make Core a top-level module (its parent is itself) instead of setting its parent to Main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usings and all bindings will now be preserved. I think the need for what we were doing is quite obsolete. This makes it easier to set upMainand make system images, since everything will come back exactly as you left it.Also make Core a top-level module (its parent is itself) instead of setting its parent to Main.