make at-sync thread safe #35641
Merged
make at-sync thread safe #35641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
reviewed
Apr 30, 2020
vtjnash
approved these changes
Apr 30, 2020
vtjnash
reviewed
Apr 30, 2020
| unlock(cond) | ||
| end | ||
| end)) | ||
| while true |
There was a problem hiding this comment.
This while true is conceptually invalid for this macro definition. This appears to possibly require changing refs into a proper Channel, rather than reimplementing it here with locks.
There was a problem hiding this comment.
What is the problem exactly?
JeffBezanson
force-pushed
the
jb/syncthreads
branch
from
14ba441 to
71593e2
Compare
vtjnash
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34666