-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define machinery so that Some can be used for broadcast #35778
Closed
Closed
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
46e45f9
Define machinery so that Some can be used for broadcast
MasonProtter eebe50d
remove erroneous Base.____
MasonProtter da00b16
another Base.___
MasonProtter f3dbe39
move Some broadcast definitions further down
MasonProtter 6a265ef
Update base/somebroadcast.jl
MasonProtter cfeeb7f
Remove superfluous eltype method
MasonProtter 43262e4
Update NEWS.md
MasonProtter efba159
make broadcastable default to Some instead of Ref
MasonProtter 9123ab9
update broadcastable docstring
MasonProtter 827b017
fix broken doctest
MasonProtter fdcdb35
it's -> its
MasonProtter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#Methods some Some can broadcast | ||
getindex(s::Some) = s.value | ||
getindex(s::Some, ::CartesianIndex{0}) = s.value | ||
|
||
iterate(s::Some) = (s.value, nothing) | ||
iterate( ::Some, s) = nothing | ||
|
||
ndims(::Some) = 0 | ||
ndims(::Type{<:Some}) = 0 | ||
|
||
length(::Some) = 1 | ||
size(::Some) = () | ||
axes(::Some) = () | ||
|
||
IteratorSize(::Type{<:Some}) = HasShape{0}() | ||
Broadcast.broadcastable(s::Some) = s | ||
|
||
eltype(::Type{Some{T}}) where {T} = T |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe more accurate to say
? Though I see that a similar wording is already used in
Ref
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like that suggestion is less likely to be understood. However, maybe not everyone knows the word "scalar" either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's fine as-is if we also explain the actual interface it implements (i.e., it is a 0-dim iterable that supports indexing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should say
its
rather thanit's
in the original formulation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yuri!