faster filesize and read(::IOStream) #35925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
performance
JeffBezanson
force-pushed
the
jb/fasterread
branch
from
29c7f5f to
8104539
Compare
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
staticfloat
reviewed
Oct 21, 2020
Comment on lines
+503
to
+504
| b = StringVector(nb) | ||
| readbytes_all!(s, b, nb) |
There was a problem hiding this comment.
We need to handle the case where this is a directory; we don't want to return a successful zero-byte read of a directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statcall for reading entire files when the file is small (<32kb, the default buffer size)readbytes_all!filesizeby using lseek instead of stat. I don't know whether this will be faster on all systems. On our end, it removes an allocation, since the stat code is quite old and uses an Array instead of a Ref to get the data from C. We might be able to remove that allocation sometimes, so I can try that too.