More invalidation fixes #35928
Merged
More invalidation fixes #35928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
May 18, 2020
|
If folks want to keep these commits separate for easier reversion in case of trouble I can rebase, or feel free to squash. |
| @@ -29,7 +29,7 @@ Base.print(io::IO, x::Enum) = print(io, Symbol(x)) | |||
|
|
|||
| function Base.show(io::IO, x::Enum) | |||
| sym = Symbol(x) | |||
| if !get(io, :compact, false) | |||
| if !(get(io, :compact, false)::Bool) | |||
There was a problem hiding this comment.
Fortunately :: already binds tighter than !, but I can see how that might not be obvious to code readers.
There was a problem hiding this comment.
i can change it, but I felt that obviousness was worth a few extra characters.
timholy
force-pushed
the
teh/ioctx_invalidations
branch
from
770c306
to
a7b178f
Compare
|
Seeing if I can trigger tests. |
All of these "fields" are documented to be Bool, so this should not break any code and may improve error messages in case of user error. Usages like `if limit...`, `limit ? a : b`, or `limit && return nothing` do not need these fixes, since these are baked into the language rather than being handled by dispatch.
This prevents invalidation via `convert(::Type{Ptr{Cint}}, fd)`.
If you know you're building args of any Expr, you might as well start out
collecting the arguments to a Vector{Any}, rather than using the clever
type-narrowing machinery of collect/map/broadcast.
timholy
force-pushed
the
teh/ioctx_invalidations
branch
from
4bda5b1
to
b4e5128
Compare
|
Barring objections, I'll merge this sometime early in the work week. |
timholy
added a commit
that referenced
this pull request
Jun 26, 2020
Failed to import Base.show in #35928
timholy
added a commit
that referenced
this pull request
Jun 30, 2020
Failed to import Base.show in #35928
jmert
added a commit
to jmert/BitFlags.jl
that referenced
this pull request
Sep 10, 2020
Duplicates the improvement made to Base's Enums: JuliaLang/julia#35928
jmert
added a commit
to jmert/BitFlags.jl
that referenced
this pull request
Sep 10, 2020
Duplicates improvement made to Base's Enums: JuliaLang/julia#35928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fix a fair number of the Base invalidations in #35922. If all these seem fine it could be merged, but many do arise from partial inference, and if we implement some of the suggestions in that issue then the changes to the following may not be so urgent:
convert(::Type{T}, x::AbstractDict) where T<:AbstractDictcmp(a::AbstractString, b::AbstractString)I doubt either of these would cause trouble, but I'm happy to drop those if Jeff or others think they are fixable by other means. To me, the rest seem like stuff we probably want.