Add bodyfunction(m::Method)
#36385
Merged
Add bodyfunction(m::Method)
#36385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There haven't been any complaints here so I'll merge tomorrow. |
KristofferC
reviewed
Aug 26, 2020
This finds the function that implements the "body" of keyword-method `m`, as generated by lowering. This addresses the "discovery" part of #30908. The renaming is done by LoweredCodeUtils.
timholy
force-pushed
the
teh/bodymethod
branch
from
ace6944 to
a712737
Compare
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
This finds the function that implements the "body" of keyword-method `m`, as generated by lowering. This addresses the "discovery" part of JuliaLang#30908. The renaming is done by LoweredCodeUtils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finds the function that implements the "body" of keyword-method
m, as generated by lowering. You can think of this as a complement toCore.kwfunc.This addresses the "discovery" part of #30908. The renaming part is done by LoweredCodeUtils. I'll let @JeffBezanson decide whether to close that issue.
This is basically copy/pasted from SnoopCompile.