-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new aarch64 cpus #36464
Add new aarch64 cpus #36464
Conversation
I'll push to this branch for update. |
Given
|
a1e2cde
to
33f374b
Compare
There are lot more to change so I squashed down to a single commit. It is possible to split it into a few different commits but it'll mainly be separated by the part of the code they touch rather than by each CPU/feature which is what was there previously. Unfortunately I still don't have a working aarch64 environment so I can't garantee the code even compile.
This is from libuv. Don't expect it to be too smart....
This should work though... |
26db08a
to
ce60c32
Compare
And in the off chance someone want to backport this. This assumes LLVM >= 8. |
ce60c32
to
60c00ad
Compare
If the LLVM line is still bad, please post your It'll also be helpful for future reference if you could run the program at |
5b849d1
to
3b1669b
Compare
It's great to be so exhaustive here. Thanks! On a Graviton2 system from the official 1.4.2 binary: cat /proc/cpuinfo
I checked a random selection through cpu0-15 and they all seem to be the same I'll retry with this PR ontop of the LLVM 10 PR |
Can you also try the C program here https://www.kernel.org/doc/html/latest/arm64/cpu-feature-registers.html#appendix-i-example ? It could be useful for some feature detection...
|
|
3b1669b
to
8b1e8ba
Compare
8b1e8ba
to
6b2c7f1
Compare
@yuyichao I'm afraid I don't know what happened here.. I didn't merge this PR but it seems a force push I did on my julia fork messed things up and the PR is now considered merged (?!). |
With the PR closed I don't think I can push to your branch anymore. I've created my branch at https://github.com/JuliaLang/julia/tree/yyc/arm/cpu . If you can't fix this PR I can open one from there. |
I've fixed the branch of this PR, but the PR seems to retain the closed state https://github.com/ianshmean/julia/commits/ib/add_aarch64_cpus It seems I accidentally force-pushed a blank branch due to in-equal states between my local git client and git cli. Github thought it was merged due to being equal to master, but now it's not equal it's not being reopened. Seems this requires a new PR. I'll open one shortly Sorry for the mixup |
Update ARM feature and CPU detection (supersedes #36464)
Adds cpu info for:
Edit: There seems to be more work needed. With this PR on a Graviton2 machine I get
unknown