A few processor detection/features tweaks #36831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Missing feature from Apple A13
* Enable Cortex-A78 and Cortex-X1 on LLVM 11
llvm/llvm-project@954db63
https://reviews.llvm.org/D83206
* More relaxed Zen detection: treat all family 23 as Zen* and treat all model >= 0x30 as Zen2.
GCC uses a similar fallback structure albeit based on feature.
This should still generate **correct** code since that is always controlled by
available features. It should be as good a scheduling model estimate as anything else.
Fix #36826
|
Added backport label here. Object if that is not a good idea. |
|
Fine for me, just that the x86 and arm parts needs the corresponding previous pr and are fixing bugs in those. I see that you’ve picked up the x86 one already so that should be fine. I’ll be very surprised if any of he hardware related to the arm fixes comes out and can run linux before Julia 1.6..... |
KristofferC
pushed a commit
that referenced
this pull request
Aug 4, 2020
* Missing feature from Apple A13
* Enable Cortex-A78 and Cortex-X1 on LLVM 11
llvm/llvm-project@954db63
https://reviews.llvm.org/D83206
* More relaxed Zen detection: treat all family 23 as Zen* and treat all model >= 0x30 as Zen2.
GCC uses a similar fallback structure albeit based on feature.
This should still generate **correct** code since that is always controlled by
available features. It should be as good a scheduling model estimate as anything else.
Fix #36826
(cherry picked from commit cd3fb4d)
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
* Missing feature from Apple A13
* Enable Cortex-A78 and Cortex-X1 on LLVM 11
llvm/llvm-project@954db63
https://reviews.llvm.org/D83206
* More relaxed Zen detection: treat all family 23 as Zen* and treat all model >= 0x30 as Zen2.
GCC uses a similar fallback structure albeit based on feature.
This should still generate **correct** code since that is always controlled by
available features. It should be as good a scheduling model estimate as anything else.
Fix JuliaLang#36826
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2020
* Missing feature from Apple A13
* Enable Cortex-A78 and Cortex-X1 on LLVM 11
llvm/llvm-project@954db63
https://reviews.llvm.org/D83206
* More relaxed Zen detection: treat all family 23 as Zen* and treat all model >= 0x30 as Zen2.
GCC uses a similar fallback structure albeit based on feature.
This should still generate **correct** code since that is always controlled by
available features. It should be as good a scheduling model estimate as anything else.
Fix #36826
(cherry picked from commit cd3fb4d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing feature from Apple A13
Enable Cortex-A78 and Cortex-X1 on LLVM 11
llvm/llvm-project@954db63
https://reviews.llvm.org/D83206
More relaxed Zen detection: treat all family 23 as Zen* and treat all model >= 0x30 as Zen2.
GCC uses a similar fallback structure albeit based on feature.
This should still generate correct code since that is always controlled by
available features. It should be as good a scheduling model estimate as anything else.
Fix Support for Renoir Zen 2 CPUs #36826