Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix markdown rendering #37235

Merged
merged 1 commit into from
Aug 28, 2020
Merged

fix markdown rendering #37235

merged 1 commit into from
Aug 28, 2020

Conversation

KristofferC
Copy link
Member

Fixes #37232.

Regressed in #36459.

@KristofferC KristofferC requested a review from timholy August 27, 2020 14:02
@KristofferC KristofferC merged commit 36505aa into master Aug 28, 2020
@KristofferC KristofferC deleted the kc/md_render branch August 28, 2020 06:46
oscardssmith pushed a commit to oscardssmith/julia that referenced this pull request Aug 28, 2020
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 29, 2020
oscardssmith added a commit to oscardssmith/julia that referenced this pull request Sep 14, 2020
author Oscar Smith <oscardssmith@gmail.com> 1595400985 -0400
committer Oscar Smith <oscardssmith@gmail.com> 1600122971 -0500

parent a0a68a5
author Oscar Smith <oscardssmith@gmail.com> 1595400985 -0400
committer Oscar Smith <oscardssmith@gmail.com> 1600122964 -0500

parent a0a68a5
author Oscar Smith <oscardssmith@gmail.com> 1595400985 -0400
committer Oscar Smith <oscardssmith@gmail.com> 1600122905 -0500

A faster version of exp for Float64

This is based on the Glibc algorithm which @chriselrod (Elrond on discourse) described the algorithm of for me. It appears to be about 2x faster than the current algorithm, and equally accurate over the range for which I have tried it. It also theoretically should be easier to vectorize as branches are only used for checking for over/underflow.

Update base/special/exp.jl

Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>

Better subnormal numbers, constant usage, and more accurate

Break r into a hi and lo part to get extra accuracy.

Fix previous comit.

Error matches gexp

Switch to minimax polynomial from taylor polynomial.

equally fast version with a smaller table.

Uses a quartic which allows a smaller table. Performance is equal to slightly better, and accuracy is similar.

fully working?

fix markdown rendering (JuliaLang#37235)

add another deprecated internal function for backwards compat (JuliaLang#36794)

Remove unnecessary volatile on memcpy (JuliaLang#37221)

This is a local bitcast of different size through memory and doesn't need to be volatile.
This was introduced due to a typo in 8e4327c when the
argument order changed and the old tbaa parameter was passed in as isvolatile.

aysnchronous typos (JuliaLang#37264)

use printf/exit instead of `jl_error` for "too many threads" (JuliaLang#37223)

This is too early for `jl_error` to work.

fix expm1 for Float32 (calling wrong libm function)

actually fix expm1

re-add exp10 docs

slightly extend upper range for Float32 arguments

re-add exp doctest, remove redundant exp10 doctest

maybe now

placing it after

use round instead of magic

re-add magic with better explanation

remove the typo

Fix all numbers taking the slow path with range checking.

Oops

Fix 32 bit build.

Use `:ℯ` instead of `float64 ℯ`

no functional change but less hacky

Update base/special/exp.jl

Co-authored-by: jmert <2965436+jmert@users.noreply.github.com>

Update base/special/exp.jl

Co-authored-by: jmert <2965436+jmert@users.noreply.github.com>

Update base/special/exp.jl

Co-authored-by: jmert <2965436+jmert@users.noreply.github.com>
timholy added a commit that referenced this pull request Nov 19, 2020
dkarrasch pushed a commit that referenced this pull request Dec 2, 2020
* Revert "fix markdown rendering (#37235)"

This reverts commit 36505aa.

* Fix Markdown word-wrap (fixes #38275)

This changes one test, but IMO the extra spaces in the test result are
not actually desirable. The alignment on Julia 1.5 is also off-by-one,
whereas this seems well-aligned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in markdown rendering in console
2 participants