Tighter array eltype for renumber_ssa
#37499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike `renumber_ssa2` in `compiler/ir.jl` which actually takes an array with elements of
many different types, all callers of `renumber_ssa` (and `renumber_ssa!`) only ever assign
`SSAValue` to the array. Also no one ever checks `isassigned` on this array
so a `Vector{SSAValue}` should work just fine here.
Try to maintain a similar level of error checking by replacing `#undef` with `SSAValue(-1)`
(already used by `construct_ssa!`) and adding an assertion in `renumber_ssa`
to check for cases that throws `UndefVarError` previously.
Also removed an unused parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
renumber_ssa2incompiler/ir.jlwhich actually takes an array with elements ofmany different types, all callers of
renumber_ssa(andrenumber_ssa!) only ever assignSSAValueto the array. Also no one ever checksisassignedon this arrayso a
Vector{SSAValue}should work just fine here.Try to maintain a similar level of error checking by replacing
#undefwithSSAValue(-1)(already used by
construct_ssa!) and adding an assertion inrenumber_ssato check for cases that throws
UndefVarErrorpreviously.Also removed an unused parameter.