Fix bug when inlining pending nodes #37634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on IR, we give pending nodes SSA ids after the main body of the function, and then we drop them in place during compaction. Inlining was using thse IDs to try to determine which basic block we're currently inlining into, but for pending blocks it was looking at the raw ID rather than the insertion position, corrupting the CFG. Fixes #37555 Fixes #37182
Keno
force-pushed
the
kf/inlinepending
branch
from
c2eef6a to
ace08d8
Compare
|
@nanosoldier |
|
Your package evaluation job has completed - possible issues were detected. A full report can be found here. cc @maleadt |
|
Well I should have triggered a vs build to see the improvments, but non of the fails look like the reported issue. |
|
any chance this could be backported to 1.5? happy to make a PR |
|
I've added the backport label, so this should be included the next 1.5.x release. |
|
Doesn't backport cleanly. Can push a backported commit to #38122 |
|
The PR that this fixed a bug in is not part of 1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on IR, we give pending nodes SSA ids after the main
body of the function, and then we drop them in place during compaction.
Inlining was using thse IDs to try to determine which basic block
we're currently inlining into, but for pending blocks it was looking
at the raw ID rather than the insertion position, corrupting the CFG.
Fixes #37555
Fixes #37182