fix bug with rand(::MersenneTwister, ::UInt128) #37808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generation of UInt64 and UInt128 share the same cache, but the routine handling generation of UInt128 was not fully aknowledging the sharing. This leads to situations like: ``` julia> m = MersenneTwister(0); rand(m, UInt64); rand(m, UInt128) 0x79ed9db9ec79a6a019c5f638a776ab3c julia> rand(m, UInt64) 0x19c5f638a776ab3c ``` Indeed, these values aren't independent enough :(
rfourquet
added
embarrassing-bugfix
krrutkow
added a commit
to krrutkow/CBinding.jl
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generation of UInt64 and UInt128 share the same cache, but the routine
handling generation of UInt128 was not fully aknowledging the sharing.
This leads to situations like:
These values aren't independent enough!