Various fixes for reinterpret(reshape, T, a)
#37858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
force-pushed
the
teh/more_reinterpretarray
branch
from
1e7c342
to
41d83b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected these while porting ImageCore to use the new
reinterpretmachinery. Most of these are no big deal, but thebase/reshapedarray.jlchange is emblematic of precisely the problem I worried about in #37559: thatIndexStylehas had just two subtypes,IndexLinearandIndexCartesian, for so long that it's likely this has been assumed to be all the possible choices. It won't be surprising if some packages need migration too.