Made \brokenbar ¦ and \notslash ⌿ infix. fixes #34651 #37973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravibitsgoa
changed the title
JeffBezanson
approved these changes
Oct 12, 2020
|
@JeffBezanson , Can this PR be merged if it is satisfactory? |
|
Needs a NEWS item |
|
Ah, turns out this does not quite work yet, since these characters are in the "So" category. |
|
So this is technically a breaking change since they are valid parts of identifiers in 1.5: julia> x¦ = 3
3
julia> x⌿ = 7
7I doubt that it will break anything in practice, but should we revert the patch and create a new PR with the modifications to |
fredrikekre
added
needs news
|
JuliaHub code search doesn't turn up any results, so it's probably ok. |
JeffBezanson
added a commit
that referenced
this pull request
Oct 19, 2020
JeffBezanson
added a commit
that referenced
this pull request
Oct 20, 2020
Merged
achuchmala
pushed a commit
to achuchmala/julia
that referenced
this pull request
Nov 11, 2020
There's also a bunch of issue links that are missing (JuliaLang#37410, JuliaLang#37247, JuliaLang#37540, JuliaLang#37973, JuliaLang#37461, JuliaLang#37753) but it seems there's a script that generates the links so I'm assuming that will be fixed automatically. Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34651