change how we document what is brought into scope #38087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good change to me but it's gotten conflicted. Would you be willing to update so we can merge? |
StefanKarpinski
approved these changes
Nov 16, 2020
|
Note that the whole chapter got rewritten. |
|
True, but I think this bit was an improvement and I believe it still roughly applies. |
|
I do not see how to incorperate this into the newly rewritten chapter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do folks think.
Is it clearer to mention that we are bring into scope the module object itself, rather than saying we were bring into scrope
MyModule.xetc?