Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define and document elsize #38128

Merged
merged 1 commit into from
Oct 27, 2020
Merged

define and document elsize #38128

merged 1 commit into from
Oct 27, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 21, 2020

Fixes #36553
Fixes regression #37438

quinnj
quinnj approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; is it worth exporting? Would that be potentially breaking if someone already has elsize and now it clashes?

@vtjnash vtjnash merged commit 6312bfe into master Oct 27, 2020
@vtjnash vtjnash deleted the jn/37438 branch October 27, 2020 14:55
@vtjnash vtjnash mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson left review comments

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Base.elsize and requirements for DenseArray subtypes better
3 participants
@vtjnash @JeffBezanson @quinnj