Rebase of #35792, add cispi function #38449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
approved these changes
Nov 15, 2020
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
jmert
added a commit
to jmert/Compat.jl
that referenced
this pull request
Nov 30, 2020
I added tests that cover both methods in Base: ```julia julia> methods(cispi) [1] cispi(theta::Real) in Base at complex.jl:544 [2] cispi(z::Complex) in Base at complex.jl:563 ``` (both of the doc tests and then a couple more examples of real inputs).
jmert
added a commit
to jmert/Compat.jl
that referenced
this pull request
Nov 30, 2020
Added to Base in JuliaLang/julia#38449 I added tests that cover both methods in Base: ```julia julia> methods(cispi) [1] cispi(theta::Real) in Base at complex.jl:544 [2] cispi(z::Complex) in Base at complex.jl:563 ``` (both of the doc tests and then a couple more examples of real inputs).
jmert
added a commit
to jmert/Compat.jl
that referenced
this pull request
Dec 12, 2020
Added to Base in JuliaLang/julia#38449 I added tests that cover both methods in Base: ```julia julia> methods(cispi) [1] cispi(theta::Real) in Base at complex.jl:544 [2] cispi(z::Complex) in Base at complex.jl:563 ``` (both of the doc tests and then a couple more examples of real inputs).
simeonschaub
pushed a commit
to JuliaLang/Compat.jl
that referenced
this pull request
Dec 13, 2020
Added to Base in JuliaLang/julia#38449 I added tests that cover both methods in Base: ```julia julia> methods(cispi) [1] cispi(theta::Real) in Base at complex.jl:544 [2] cispi(z::Complex) in Base at complex.jl:563 ``` (both of the doc tests and then a couple more examples of real inputs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #35792 with the couple of uncommitted review comments applied that undo the specializations on integer types. I think the only remaining task was to then remove the doc strings referencing the relation between
cispiandsignbit(which no longer exists once the Integer specializations are removed).