inference: stop re-converging worlds after optimization #38820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validity did not change, so we should not need to update it. This also ensures we copy over all result information earlier, so we can destroy the InferenceState slightly sooner, and slightly cleaner data flow.
|
LGTM in general, but I had earlier tried a change like this and saw measureable regressions in sysimg build time? Does that happen here also? |
Keno
reviewed
Dec 12, 2020
| end | ||
| if last(valid_worlds) == typemax(UInt) | ||
| if doopt && last(valid_worlds) == typemax(UInt) |
There was a problem hiding this comment.
Why not move this up into the previous loop at this point?
There was a problem hiding this comment.
This step might require taking a lock (since we're updating a few different caches, that all need to happen at once), so I like having them appear separately, though it's not essential.
|
I instrumented this to show that it never made a difference, while building the system image, on the world ages that we cached. Seems to also run at about the same speed. |
Keno
approved these changes
Dec 12, 2020
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Dec 21, 2020
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Dec 21, 2020
KristofferC
pushed a commit
that referenced
this pull request
Jan 21, 2021
The validity did not change, so we should not need to update it. This also ensures we copy over all result information earlier, so we can destroy the InferenceState slightly sooner, and slightly cleaner data flow. (cherry picked from commit 8c01444)
vtjnash
added a commit
that referenced
this pull request
Jan 21, 2021
The validity did not change, so we should not need to update it. This also ensures we copy over all result information earlier, so we can destroy the InferenceState slightly sooner, and slightly cleaner data flow. (cherry picked from commit 8c01444)
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
The validity did not change, so we should not need to update it. This also ensures we copy over all result information earlier, so we can destroy the InferenceState slightly sooner, and slightly cleaner data flow. (cherry picked from commit 8c01444)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
The validity did not change, so we should not need to update it. This also ensures we copy over all result information earlier, so we can destroy the InferenceState slightly sooner, and slightly cleaner data flow. (cherry picked from commit 8c01444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validity did not change, so we should not need to update it. This
also ensures we copy over all result information earlier, so we can
destroy the InferenceState slightly sooner, and slightly cleaner data flow.
This is preparatory work for further reorganization of how optimization choices are ordered (#38231).