Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix erroneous code path within show_sym #38830

Merged
merged 2 commits into from
Dec 14, 2020
Merged

fix erroneous code path within show_sym #38830

merged 2 commits into from
Dec 14, 2020

Commits on Dec 11, 2020

  1. fix erroneous code path within show_sym 

    currently, `show_sym` can recur into `show(::IO, String)`, but it's a
bit "erroneous" since `is_syntactic_operator(::String)` is not defined.

the virtual stacktrace from [JET.jl](https://github.com/aviatesk/JET.jl)
may describe this better:
```julia
julia> @report_call println(QuoteNode(nothing))
═════ 1 possible error found ═════
┌ @ coreio.jl:4 Base.println(Core.tuple(Core.typeassert(Base.stdout, 
Base.IO)), xs...)
│┌ @ strings/io.jl:73 Base.print(Core.tuple(io), xs, 
Core.tuple("\n")...)
││┌ @ strings/io.jl:46 Base.print(io, x)
│││┌ @ show.jl:1144 Base.show_unquoted(Base.IOContext(io, 
Base.=>(:unquote_fallback, false)), ex, 0, -1)
││││┌ @ show.jl:1496 Base.show_unquoted_quote_expr(io, 
Base.getproperty(ex, :value), indent, prec, 0)
│││││┌ @ show.jl:1522 Base.show_block(Base.IOContext(io, 
Base.=>(Base.beginsym, false)), "quote", value, indent, quote_level)
││││││┌ @ show.jl:1365 Base.show_block(io, head, Base.vect(), block, i, 
quote_level)
│││││││┌ @ show.jl:1361 Base.show_unquoted(io, ex, ind, -1, quote_level)
││││││││┌ @ show.jl:1955 
Core.kwfunc(Base.show_globalref)(Core.apply_type(Core.NamedTuple, 
(:allow_macroname,))(Core.tuple(true)), Base.show_globalref, io, arg1)
│││││││││┌ @ show.jl:1468 Base.#show_globalref#424(allow_macroname, _3, 
io, ex)
││││││││││┌ @ show.jl:1474 
Core.kwfunc(Base.show_sym)(Core.apply_type(Core.NamedTuple, 
(:allow_macroname,))(Core.tuple(allow_macroname)), Base.show_sym, io, 
Base.getproperty(ex, :name))
│││││││││││┌ @ REPL[7]:2 Base.#show_sym#882(allow_macroname, _3, io, 
sym)
││││││││││││┌ @ REPL[7]:6 Base.show_sym(io, Base.getindex(sym_str, 
Base.:(2, Base.lastindex(sym_str))))
│││││││││││││┌ @ REPL[7]:2 Base.#show_sym#882(false, #self#, io, sym)
││││││││││││││┌ @ REPL[7]:2 Base.is_valid_identifier(sym)
│││││││││││││││┌ @ show.jl:1410 Base.is_syntactic_operator(sym)
││││││││││││││││ no matching method found for call signature: 
Base.is_syntactic_operator(sym::String)
│││││││││││││││└────────────────
Core.Const(nothing)

julia> # fix this
       @eval Base function show_sym(io::IO, sym; allow_macroname=false)
           if is_valid_identifier(sym)
               print(io, sym)
           elseif allow_macroname && (sym_str = string(sym); 
startswith(sym_str, '@'))
               print(io, '@')
               show_sym(io, Symbol(sym_str[2:end]))
           else
               print(io, "var", repr(string(sym)))
           end
       end
show_sym (generic function with 1 method)

julia> @report_call println(QuoteNode(nothing))
No errors !
Core.Const(nothing)
```
    @aviatesk
    aviatesk committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    fb95c24 View commit details
    Browse the repository at this point in the history

  2. explicit argument type for show_sym

    @aviatesk
    aviatesk committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    f13c310 View commit details
    Browse the repository at this point in the history