rm unnecessary widenconst_bestguess call
#38871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the equivalent widening logic is imposed within `typeinf_local`, and so as far as I understand we don't this need `widenconst_bestguess` in `typeinf_edge`
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Dec 16, 2020
vtjnash
pushed a commit
that referenced
this pull request
Jan 21, 2021
the equivalent widening logic is imposed within `typeinf_local`, and so as far as I understand we don't this need `widenconst_bestguess` in `typeinf_edge` (cherry picked from commit 341d6c9)
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
the equivalent widening logic is imposed within `typeinf_local`, and so as far as I understand we don't this need `widenconst_bestguess` in `typeinf_edge` (cherry picked from commit 341d6c9)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
the equivalent widening logic is imposed within `typeinf_local`, and so as far as I understand we don't this need `widenconst_bestguess` in `typeinf_edge`
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
the equivalent widening logic is imposed within `typeinf_local`, and so as far as I understand we don't this need `widenconst_bestguess` in `typeinf_edge` (cherry picked from commit 341d6c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the equivalent widening logic is imposed on
frame.bestguesswithintypeinf_local, and so as far as I understand we don't needwidenconst_bestguessintypeinf_edge