Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some costly precompiles #39179

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Add some costly precompiles #39179

merged 1 commit into from
Jan 13, 2021

Conversation

timholy
Copy link
Sponsor Member

@timholy timholy commented Jan 10, 2021

These are things that have shown up in analysis of various packages
by SnoopCompile. Either they are particularly costly, or in the
case of Test, just plain annoying to have them show up again
and again.

Complementary (but independent) PR: #39177
Most of the remaining Test-related inference triggers I've discovered are due to #34516

These are things that have shown up in analysis of various packages
by SnoopCompile. Either they are particularly costly, or in the
case of `Test`, just plain annoying to have them show up again
and again.
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially LGTM! I trust that the choices are sound :).

@mbauman mbauman added the compiler:latency Compiler latency label Jan 12, 2021
@timholy timholy merged commit 886f89c into master Jan 13, 2021
@timholy timholy deleted the teh/more_precompile branch January 13, 2021 07:22
@oscardssmith
Copy link
Member

Since adding precompiles really should be non-breaking, is this backportable to 1.6?

ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
These are things that have shown up in analysis of various packages
by SnoopCompile. Either they are particularly costly, or in the
case of `Test`, just plain annoying to have them show up again
and again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:latency Compiler latency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants