fix some issues with inference Conditionals #39221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try harder to equate Const(bool) with the Conditional represenation of the same
Missed in dcc0696 cleanup
Rename typeassert_type_instance to tjoin (aka typeintersect). Also, since the ifelse value here might not be in the regular type lattice, we need to use the extended lattice for this evaluation.
|
Backport candidate? :) (Edit: Preemptively added the label so that this pull request doesn't get lost. Please feel welcome to remove if these changes shouldn't be backported.) |
This was referenced Jan 14, 2021
Merged
|
Yes, but avoid backporting e1859a1, as that commit is 100% wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.