Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force-specialize on T in cat_similar #39292

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Force-specialize on T in cat_similar #39292

merged 1 commit into from
Jan 19, 2021

Conversation

timholy
Copy link
Member

@timholy timholy commented Jan 17, 2021

These methods are tiny (quick to compile), call methods
that force-specialize on T, and are called by methods
that force-specialize on T. Consequently, there does not
seem to be any good reason to lose inferrability in these methods.

@timholy
Force-specialize on T in cat_similar
60cbda8 
These methods are tiny (quick to compile), call methods
that force-specialize on `T`, and are called by methods
that force-specialize on `T`. Consequently, there does not
seem to be any good reason to lose inferrability in these methods.
@timholy timholy mentioned this pull request Jan 18, 2021
Merged
@timholy timholy merged commit 33573ec into master Jan 19, 2021
@timholy timholy deleted the teh/cat_specialize branch January 19, 2021 07:48
timholy added a commit that referenced this pull request Jan 19, 2021
@timholy
Use lispy tuples in cat (fixes #21673)
3b2407a 
The `cat` pipeline has long had poor inferrability.
Together with #39292 and #39294, this should basically put an
end to that problem.

Together, at least in simple cases these make the performance
of `cat` essentially equivalent to the manual version.
In other words, the `test1` and `test2` of #21673 benchmark
very similarly.
This was referenced Jan 19, 2021
Merged
Closed
@timholy timholy added the backport 1.6 Change should be backported to release-1.6 label Jan 19, 2021
timholy added a commit that referenced this pull request Jan 20, 2021
@timholy
Use lispy tuples in cat (fixes #21673) (#39314)
78d55e2 
The `cat` pipeline has long had poor inferrability.
Together with #39292 and #39294, this should basically put an
end to that problem.

Together, at least in simple cases these make the performance
of `cat` essentially equivalent to the manual version.
In other words, the `test1` and `test2` of #21673 benchmark
very similarly.
KristofferC pushed a commit that referenced this pull request Jan 20, 2021
@timholy @KristofferC
Force-specialize on T in cat_similar (#39292)
4904312 
These methods are tiny (quick to compile), call methods
that force-specialize on `T`, and are called by methods
that force-specialize on `T`. Consequently, there does not
seem to be any good reason to lose inferrability in these methods.

(cherry picked from commit 33573ec)
KristofferC pushed a commit that referenced this pull request Jan 20, 2021
@timholy @KristofferC
Use lispy tuples in cat (fixes #21673) (#39314)
4c08189 
The `cat` pipeline has long had poor inferrability.
Together with #39292 and #39294, this should basically put an
end to that problem.

Together, at least in simple cases these make the performance
of `cat` essentially equivalent to the manual version.
In other words, the `test1` and `test2` of #21673 benchmark
very similarly.

(cherry picked from commit 78d55e2)
@KristofferC KristofferC mentioned this pull request Jan 20, 2021
Merged
60 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Feb 1, 2021
KristofferC pushed a commit that referenced this pull request Feb 1, 2021
@timholy @KristofferC
Force-specialize on T in cat_similar (#39292)
bf47097 
These methods are tiny (quick to compile), call methods
that force-specialize on `T`, and are called by methods
that force-specialize on `T`. Consequently, there does not
seem to be any good reason to lose inferrability in these methods.

(cherry picked from commit 33573ec)
KristofferC pushed a commit that referenced this pull request Feb 1, 2021
@timholy @KristofferC
Use lispy tuples in cat (fixes #21673) (#39314)
10b744a 
The `cat` pipeline has long had poor inferrability.
Together with #39292 and #39294, this should basically put an
end to that problem.

Together, at least in simple cases these make the performance
of `cat` essentially equivalent to the manual version.
In other words, the `test1` and `test2` of #21673 benchmark
very similarly.

(cherry picked from commit 78d55e2)
@timholy timholy mentioned this pull request Feb 19, 2021
Open
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@timholy @ElOceanografo
Force-specialize on T in cat_similar (JuliaLang#39292)
dd8eef7 
These methods are tiny (quick to compile), call methods
that force-specialize on `T`, and are called by methods
that force-specialize on `T`. Consequently, there does not
seem to be any good reason to lose inferrability in these methods.
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@timholy @ElOceanografo
Use lispy tuples in cat (fixes JuliaLang#21673) (JuliaLang#39314)
98546c0 
The `cat` pipeline has long had poor inferrability.
Together with JuliaLang#39292 and JuliaLang#39294, this should basically put an
end to that problem.

Together, at least in simple cases these make the performance
of `cat` essentially equivalent to the manual version.
In other words, the `test1` and `test2` of JuliaLang#21673 benchmark
very similarly.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@timholy @antoine-levitt
Force-specialize on T in cat_similar (JuliaLang#39292)
8f24637 
These methods are tiny (quick to compile), call methods
that force-specialize on `T`, and are called by methods
that force-specialize on `T`. Consequently, there does not
seem to be any good reason to lose inferrability in these methods.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@timholy @antoine-levitt
Use lispy tuples in cat (fixes JuliaLang#21673) (JuliaLang#39314)
2435678 
The `cat` pipeline has long had poor inferrability.
Together with JuliaLang#39292 and JuliaLang#39294, this should basically put an
end to that problem.

Together, at least in simple cases these make the performance
of `cat` essentially equivalent to the manual version.
In other words, the `test1` and `test2` of JuliaLang#21673 benchmark
very similarly.
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@timholy @staticfloat
Force-specialize on T in cat_similar (#39292)
2c04b23 
These methods are tiny (quick to compile), call methods
that force-specialize on `T`, and are called by methods
that force-specialize on `T`. Consequently, there does not
seem to be any good reason to lose inferrability in these methods.

(cherry picked from commit 33573ec)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@timholy @staticfloat
Use lispy tuples in cat (fixes #21673) (#39314)
58bdaf5 
The `cat` pipeline has long had poor inferrability.
Together with #39292 and #39294, this should basically put an
end to that problem.

Together, at least in simple cases these make the performance
of `cat` essentially equivalent to the manual version.
In other words, the `test1` and `test2` of #21673 benchmark
very similarly.

(cherry picked from commit 78d55e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timholy @Sacha0 @KristofferC