Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase: Performance regression of scalar randn() between Julia 1.4 and 1.5 #39319

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Rebase: Performance regression of scalar randn() between Julia 1.4 and 1.5 #39319

merged 3 commits into from
Jan 19, 2021

Conversation

KristofferC
Copy link
Member

Rebase of #37234

@KristofferC KristofferC added this to the 1.6 blockers milestone Jan 19, 2021
@KristofferC KristofferC mentioned this pull request Jan 19, 2021
Closed
@rfourquet
Copy link
Member

rfourquet commented Jan 19, 2021 •
edited
Loading

Was merging this discussed somewhere recently? Given that randn(rng) seems to have got its performance back compared to Julia 1.4, what about waiting for #38231? (if this ever lands)

@KristofferC
Copy link
Member Author

I think it was discussed that its fine to put this in as a workaround while waiting for that PR.

@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label Jan 19, 2021
@KristofferC
Copy link
Member Author

Test failure is #39040

@KristofferC KristofferC merged commit 6813340 into master Jan 19, 2021
@KristofferC KristofferC deleted the lungben-randn_performance branch January 19, 2021 21:37
KristofferC added a commit that referenced this pull request Jan 19, 2021
@KristofferC
Rebase: Performance regression of scalar randn() between Julia 1.4 an…
fdf9ea2 
…d 1.5 (#39319)

* definition of randn for scalars reverted to 1.4

* Added comments why this change is done

Co-authored-by: Benjamin Lungwitz <52384612+lungben@users.noreply.github.com>
(cherry picked from commit 6813340)
@KristofferC KristofferC mentioned this pull request Jan 19, 2021
Merged
60 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Feb 1, 2021
KristofferC added a commit that referenced this pull request Feb 1, 2021
@KristofferC
Rebase: Performance regression of scalar randn() between Julia 1.4 an…
484745c 
…d 1.5 (#39319)

* definition of randn for scalars reverted to 1.4

* Added comments why this change is done

Co-authored-by: Benjamin Lungwitz <52384612+lungben@users.noreply.github.com>
(cherry picked from commit 6813340)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@KristofferC @lungben @ElOceanografo
Rebase: Performance regression of scalar randn() between Julia 1.4 an…
27b2911 
…d 1.5 (JuliaLang#39319)

* definition of randn for scalars reverted to 1.4

* Added comments why this change is done

Co-authored-by: Benjamin Lungwitz <52384612+lungben@users.noreply.github.com>
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@KristofferC @lungben @antoine-levitt
Rebase: Performance regression of scalar randn() between Julia 1.4 an…
ce5a376 
…d 1.5 (JuliaLang#39319)

* definition of randn for scalars reverted to 1.4

* Added comments why this change is done

Co-authored-by: Benjamin Lungwitz <52384612+lungben@users.noreply.github.com>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@KristofferC @staticfloat
Rebase: Performance regression of scalar randn() between Julia 1.4 an…
7f61389 
…d 1.5 (#39319)

* definition of randn for scalars reverted to 1.4

* Added comments why this change is done

Co-authored-by: Benjamin Lungwitz <52384612+lungben@users.noreply.github.com>
(cherry picked from commit 6813340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KristofferC @rfourquet @lungben