-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't touch gvars when compiling for an external back-end. #39387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
compiler:codegen
Generation of LLVM IR and native code
gpu
Affects running Julia on a GPU
labels
Jan 25, 2021
vchuravy
reviewed
Jan 25, 2021
F->setPersonalityFn(juliapersonality_func); | ||
// Add unwind exception personalities to functions to handle async exceptions | ||
if (Function *F = dyn_cast<Function>(&G)) | ||
F->setPersonalityFn(juliapersonality_func); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Means backends will have to initialize the personality functions themselves, but I suspect that's okay.
vchuravy
approved these changes
Jan 25, 2021
jpsamaroo
reviewed
Jan 25, 2021
Co-authored-by: Julian Samaroo <jpsamaroo@jpsamaroo.me>
jpsamaroo
approved these changes
Jan 25, 2021
CI failures unrelated (Profile, timeout). |
Might have been good to squash. |
Ah, of course... 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in JuliaGPU/CUDA.jl#552 that exported global variables in an
llvmcall
got internalized along the way:It seems like this functionality should not trigger when compiling for an external compiler back-end.
FWIW, regular
@code_llvm
does not trigger this conversion, so just doing@code_llvm dump_module=true main()
still results in: