Small improvements to Timer #39510
Merged
Small improvements to Timer #39510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Feb 4, 2021
vtjnash
reviewed
Feb 4, 2021
vtjnash
reviewed
Feb 4, 2021
This is a performance/memory optimization: previously, it would start running at an indeterminate time between when it was defined and when it was needed, possibly wasting memory until then.
|
I think this is fine for now. |
| @@ -72,7 +75,7 @@ mutable struct Timer | |||
| timeout ≥ 0 || throw(ArgumentError("timer cannot have negative timeout of $timeout seconds")) | |||
| interval ≥ 0 || throw(ArgumentError("timer cannot have negative repeat interval of $interval seconds")) | |||
| timeout = UInt64(round(timeout * 1000)) + 1 | |||
| interval = UInt64(round(interval * 1000)) | |||
| interval = UInt64(ceil(interval * 1000)) | |||
There was a problem hiding this comment.
Would it make more sense to make sure that interval is at least 1 if it is greater than zero on the way in?
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* delay launching Task until just before it is needed This is a performance/memory optimization: previously, it would start running at an indeterminate time between when it was defined and when it was needed, possibly wasting memory until then. * Timer: don't create a one-shot timer * Timer: Don't fail silently when callback fails Co-authored-by: Jameson Nash <jameson@juliacomputing.com>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* delay launching Task until just before it is needed This is a performance/memory optimization: previously, it would start running at an indeterminate time between when it was defined and when it was needed, possibly wasting memory until then. * Timer: don't create a one-shot timer * Timer: Don't fail silently when callback fails Co-authored-by: Jameson Nash <jameson@juliacomputing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much frustration today debugging timer code it boiled down to two things:
intervalis to small we round to 0 and accidentially create a one-shot timer