-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reductions of Transpose, Adjoint, PermutedDimsArray #39513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
commented
Feb 4, 2021
vtjnash
reviewed
Apr 16, 2021
vtjnash
reviewed
Apr 16, 2021
vtjnash
approved these changes
Apr 16, 2021
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
vtjnash
added
merge me
PR is reviewed. Merge when all tests are passing
and removed
forget me not
PRs that one wants to make sure aren't forgotten
labels
Apr 16, 2021
simeonschaub
removed
the
merge me
PR is reviewed. Merge when all tests are passing
label
Apr 28, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
This doesn't seem speed up julia> X = randn(5000, 200);
julia> @btime maximum($X);
636.708 μs (0 allocations: 0 bytes)
julia> @btime maximum(transpose($X));
4.643 ms (0 allocations: 0 bytes)
julia> @btime maximum($X; dims=1);
744.458 μs (4 allocations: 1.88 KiB)
julia> @btime maximum(transpose($X); dims=2);
4.644 ms (14 allocations: 2.06 KiB) although
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33029.
It also adds some methods toNow removed, in favour of an explicit∘
such thatadjoint ∘ identity ∘ adjoint === identity
, since it will tend to produce such combinations, and something else may wish to dispatch on them. But it would work without this, I can separate it if that's preferable. (Perhaps we should also complete the group withconj ∘ transpose = adjoint
etc.)_sandwich
function.The reduction functions which this overloads for
PermutedDimsArray
were defined after its file is loaded. I moved this file later, but could equally well move these methods to another file.