Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loading] Search in Sys.STDLIB if name/uuid is known. #39572

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

fredrikekre
Copy link
Member

Locating a package with known uuid means the uuid was either
found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH.
However, this lookup fails for stdlibs that are not in the sysimage,
even if they have been explicitly added to project/manifest by the
user. This patch allows looking in Sys.STDLIB for stdlibs,
fixes #39504.

@fredrikekre fredrikekre added backport 1.6 Change should be backported to release-1.6 packages Package management and loading labels Feb 8, 2021
@DilumAluthge
Copy link
Member

Should this be added to the 1.6 blockers milestone?

Locating a package with known uuid means the uuid was either
found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH.
However, looking up the package entrypoint fails for stdlibs that
are not in the sysimage, even if they have been explicitly added
to project/manifest by the user. This patch allows looking in
Sys.STDLIB after stdlibs, fixes #39504.
@fredrikekre fredrikekre merged commit 5d7e13f into master Feb 9, 2021
@fredrikekre fredrikekre deleted the fe/stdlib-loading branch February 9, 2021 21:25
KristofferC pushed a commit that referenced this pull request Feb 11, 2021
Locating a package with known uuid means the uuid was either
found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH.
However, looking up the package entrypoint fails for stdlibs that
are not in the sysimage, even if they have been explicitly added
to project/manifest by the user. This patch allows looking in
Sys.STDLIB after stdlibs, fixes #39504.

(cherry picked from commit 5d7e13f)
@KristofferC KristofferC mentioned this pull request Feb 11, 2021
52 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 14, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
Locating a package with known uuid means the uuid was either
found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH.
However, looking up the package entrypoint fails for stdlibs that
are not in the sysimage, even if they have been explicitly added
to project/manifest by the user. This patch allows looking in
Sys.STDLIB after stdlibs, fixes JuliaLang#39504.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
Locating a package with known uuid means the uuid was either
found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH.
However, looking up the package entrypoint fails for stdlibs that
are not in the sysimage, even if they have been explicitly added
to project/manifest by the user. This patch allows looking in
Sys.STDLIB after stdlibs, fixes JuliaLang#39504.
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Locating a package with known uuid means the uuid was either
found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH.
However, looking up the package entrypoint fails for stdlibs that
are not in the sysimage, even if they have been explicitly added
to project/manifest by the user. This patch allows looking in
Sys.STDLIB after stdlibs, fixes #39504.

(cherry picked from commit 5d7e13f)
KristofferC pushed a commit to JuliaLang/Pkg.jl that referenced this pull request Oct 3, 2023
KristofferC added a commit to JuliaLang/Pkg.jl that referenced this pull request Oct 9, 2023
IanButterworth pushed a commit to JuliaLang/Pkg.jl that referenced this pull request Oct 10, 2023
…nifest (#3640)

this should not be needed after JuliaLang/julia#39572

(cherry picked from commit debcade)
IanButterworth pushed a commit to JuliaLang/Pkg.jl that referenced this pull request Oct 31, 2023
…nifest (#3640)

this should not be needed after JuliaLang/julia#39572

(cherry picked from commit debcade)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Package management and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code loading can not find stdlibs outside the sysimage
5 participants