-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loading] Search in Sys.STDLIB if name/uuid is known. #39572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
added
backport 1.6
Change should be backported to release-1.6
packages
Package management and loading
labels
Feb 8, 2021
Should this be added to the 1.6 blockers milestone? |
vtjnash
approved these changes
Feb 8, 2021
fredrikekre
force-pushed
the
fe/stdlib-loading
branch
from
February 9, 2021 08:06
b3610a8
to
4d7cfb0
Compare
Locating a package with known uuid means the uuid was either found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH. However, looking up the package entrypoint fails for stdlibs that are not in the sysimage, even if they have been explicitly added to project/manifest by the user. This patch allows looking in Sys.STDLIB after stdlibs, fixes #39504.
fredrikekre
force-pushed
the
fe/stdlib-loading
branch
from
February 9, 2021 15:39
4d7cfb0
to
77e1aa1
Compare
Sacha0
approved these changes
Feb 9, 2021
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2021
Locating a package with known uuid means the uuid was either found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH. However, looking up the package entrypoint fails for stdlibs that are not in the sysimage, even if they have been explicitly added to project/manifest by the user. This patch allows looking in Sys.STDLIB after stdlibs, fixes #39504. (cherry picked from commit 5d7e13f)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Locating a package with known uuid means the uuid was either found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH. However, looking up the package entrypoint fails for stdlibs that are not in the sysimage, even if they have been explicitly added to project/manifest by the user. This patch allows looking in Sys.STDLIB after stdlibs, fixes JuliaLang#39504.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
Locating a package with known uuid means the uuid was either found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH. However, looking up the package entrypoint fails for stdlibs that are not in the sysimage, even if they have been explicitly added to project/manifest by the user. This patch allows looking in Sys.STDLIB after stdlibs, fixes JuliaLang#39504.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Locating a package with known uuid means the uuid was either found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH. However, looking up the package entrypoint fails for stdlibs that are not in the sysimage, even if they have been explicitly added to project/manifest by the user. This patch allows looking in Sys.STDLIB after stdlibs, fixes #39504. (cherry picked from commit 5d7e13f)
KristofferC
pushed a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Oct 3, 2023
…nifest this should not be needed after JuliaLang/julia#39572
KristofferC
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Oct 9, 2023
…nifest (#3640) this should not be needed after JuliaLang/julia#39572
IanButterworth
pushed a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Oct 10, 2023
…nifest (#3640) this should not be needed after JuliaLang/julia#39572 (cherry picked from commit debcade)
IanButterworth
pushed a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Oct 31, 2023
…nifest (#3640) this should not be needed after JuliaLang/julia#39572 (cherry picked from commit debcade)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locating a package with known uuid means the uuid was either
found in a manifest in LOAD_PATH or a "package folder" in LOAD_PATH.
However, this lookup fails for stdlibs that are not in the sysimage,
even if they have been explicitly added to project/manifest by the
user. This patch allows looking in Sys.STDLIB for stdlibs,
fixes #39504.